Skip to content

Send sendKeyPress event across DAP for temporary integrated consoles#1791

Merged
andyleejordan merged 2 commits into
masterfrom
andschwa/fix-temp-console
May 5, 2022
Merged

Send sendKeyPress event across DAP for temporary integrated consoles#1791
andyleejordan merged 2 commits into
masterfrom
andschwa/fix-temp-console

Conversation

@andyleejordan

Copy link
Copy Markdown
Member

This is kind of messy, but it fixes PowerShell/vscode-powershell#3950.

@SeeminglyScience SeeminglyScience left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small naming suggestion

Comment thread src/PowerShellEditorServices/Services/PowerShell/Host/PsesInternalHost.cs Outdated
Comment thread src/PowerShellEditorServices/Services/PowerShell/Host/PsesInternalHost.cs Outdated
Comment thread src/PowerShellEditorServices/Server/PsesDebugServer.cs Outdated
Co-authored-by: Patrick Meinecke <SeeminglyScience@users.noreply.github.com>
@andyleejordan
andyleejordan enabled auto-merge (squash) May 5, 2022 19:20
@andyleejordan
andyleejordan merged commit dd870ec into master May 5, 2022
@andyleejordan
andyleejordan deleted the andschwa/fix-temp-console branch May 5, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Temporary integrated consoles stuck waiting for key press

2 participants