Skip to content

Wrap script paths with single instead of double quotes - #1940

Merged
andyleejordan merged 1 commit into
mainfrom
andschwa/single-quote-scripts
Nov 2, 2022
Merged

Wrap script paths with single instead of double quotes#1940
andyleejordan merged 1 commit into
mainfrom
andschwa/single-quote-scripts

Conversation

@andyleejordan

Copy link
Copy Markdown
Member

In order to support funny path names with dollar signs. Also this is what PowerShell does by default (e.g. through tab-completion).

Resolves PowerShell/vscode-powershell#4238.

@andyleejordan
andyleejordan requested a review from a team November 2, 2022 19:09
@andyleejordan
andyleejordan enabled auto-merge (squash) November 2, 2022 19:10

@SeeminglyScience SeeminglyScience left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

In order to support funny path names with dollar signs. Also this is
what PowerShell does by default (e.g. through tab-completion).
@andyleejordan
andyleejordan force-pushed the andschwa/single-quote-scripts branch from 5c0438e to 86aa91c Compare November 2, 2022 19:52
@andyleejordan
andyleejordan merged commit ed655ae into main Nov 2, 2022
@andyleejordan
andyleejordan deleted the andschwa/single-quote-scripts branch November 2, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

F5 uses double quotes around script's path to dot-source/run script (instead of single quotes)

2 participants