Skip to content

Escape single quotes when launching a script by path - #1957

Merged
andyleejordan merged 1 commit into
mainfrom
andschwa/escape-single-quotes
Nov 18, 2022
Merged

Escape single quotes when launching a script by path#1957
andyleejordan merged 1 commit into
mainfrom
andschwa/escape-single-quotes

Conversation

@andyleejordan

@andyleejordan andyleejordan commented Nov 17, 2022

Copy link
Copy Markdown
Member

Since we surround it with single quotes.

Resolves PowerShell/vscode-powershell#4269 with tests.

@andyleejordan
andyleejordan requested a review from a team November 17, 2022 22:00

@SeeminglyScience SeeminglyScience left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Since we surround it with single quotes.
@andyleejordan
andyleejordan force-pushed the andschwa/escape-single-quotes branch from 76cfca3 to b872035 Compare November 18, 2022 22:06
@andyleejordan
andyleejordan enabled auto-merge (squash) November 18, 2022 22:07
@andyleejordan
andyleejordan enabled auto-merge (squash) November 18, 2022 22:07
@andyleejordan
andyleejordan merged commit d2e6e71 into main Nov 18, 2022
@andyleejordan
andyleejordan deleted the andschwa/escape-single-quotes branch November 18, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

F5 with script containing single quotes results in 'not recognized as a ....' error

2 participants