Simplify checkpoint saver and loader#1234
Merged
wyli merged 5 commits intoNov 16, 2020
Merged
Conversation
merge master
merge master
[DLMED] fix torchscript issue in densenet (#1114)
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Nic-Ma
changed the title
wyli
approved these changes
Nov 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removed some unnecessary hack logic in
CheckpointSaverandCheckpointLoaderhandlers as ignite already integrated these features in v0.4.2 @vfdev-5 :https://github.com/pytorch/ignite/blob/v0.4.2/ignite/handlers/checkpoint.py#L382
https://github.com/pytorch/ignite/blob/v0.4.2/ignite/handlers/checkpoint.py#L494
https://github.com/pytorch/ignite/blob/v0.4.2/ignite/handlers/checkpoint.py#L496
And ignite supports more cases than our previous hack.
Status
Ready
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.