Skip to content

AVFormat property start_time_realtime available in input container. - #975

Closed
karoldob wants to merge 2 commits into
PyAV-Org:mainfrom
karoldob:main
Closed

AVFormat property start_time_realtime available in input container.#975
karoldob wants to merge 2 commits into
PyAV-Org:mainfrom
karoldob:main

Conversation

@karoldob

@karoldob karoldob commented Apr 26, 2022

Copy link
Copy Markdown

start_time_realtime is useful if you want to synchronize multiple video streams.

@karoldob
karoldob marked this pull request as ready for review April 26, 2022 14:26
@jlaine

jlaine commented Apr 26, 2022

Copy link
Copy Markdown
Member

Let's have a docstring + a unit test for this new property.

@karoldob

Copy link
Copy Markdown
Author

Sorry I had some issues with identites.
Docs, tests are ready

@karoldob karoldob reopened this Apr 26, 2022
@jlaine

jlaine commented Apr 27, 2022

Copy link
Copy Markdown
Member

Ouch I hadn't fully thought through my request for a unit test for this.. We already have a ticket complaining our test suite depends on network access, and this only makes this even more true!

Comment thread tests/test_rtspstarttimerealtime.py Outdated
@karoldob

karoldob commented Jul 12, 2022

Copy link
Copy Markdown
Author

Hi @jlaine all your suggestions are fixed. It looks label 'change requested` could be removed :)
Anything other blocks this merge?

@jlaine

jlaine commented Oct 17, 2022

Copy link
Copy Markdown
Member

@karoldob what was blocking was my lack of time :) I've rebased your code on top of master, with a slightly reworded docstring. Let's see how CI goes, I'm hoping to get this in for the next release which should be very soon.

@jlaine

jlaine commented Oct 17, 2022

Copy link
Copy Markdown
Member

Hm, it looks as though rtsp.stream is no longer available. That might be for the best, as increasing our dependency on "having network access" is not something I was looking forward to. I wonder if we can spin up our own RTSP server using PyAV?

@WyattBlue
WyattBlue changed the base branch from main to wyattdummy November 25, 2023 07:46
@WyattBlue
WyattBlue changed the base branch from wyattdummy to main November 25, 2023 07:47
@WyattBlue

Copy link
Copy Markdown
Member

This commit doesn't work anymore and don't care about this enough to fix it myself, so I will be closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants