Adaptive over-sampling: replace trailing sub_size 1 with 2 - #53
Merged
Conversation
Adaptive schemes ([4,2,1] / [8,4,1] with radial_list=[0.3,0.6]) dropped to sub_size 1 beyond 0.6", evaluating the lensed source's arcs with no over-sampling. With MGE sources this aliases compact Gaussians and degrades gradient-based searches. Every trailing 1 becomes 2; simulators ([32,8,2]) unchanged. Guide prose updated to the MGE-era justification. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tutorial-wide sweep replacing trailing sub_size 1 with 2 in adaptive over-sampling schemes (
[8, 4, 1]→[8, 4, 2]), keeping a 2x2 outer floor so compact light profiles (e.g. MGE Gaussians) are never evaluated once-per-pixel — the resulting aliasing degrades gradient-based searches. Mirrors PyAutoLabs/autolens_workspace#443.Scripts Changed
sub_size_listsweep as aboveTest Plan
sub_size_list=[…, 1]remaining (regex-verified)Generated by the PyAutoLabs agent workflow.