Skip to content

fix: correct unphysical ell_comps in tutorial 3 model-fitting exercise #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jammy2211 merged 1 commit into from
Aug 13, 2026
Merged

fix: correct unphysical ell_comps in tutorial 3 model-fitting exercise #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion markdown/chapter_1_introduction/tutorial_3_fitting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,7 +938,7 @@ galaxy = ag.Galaxy(
redshift=0.5,
bulge=ag.lp.Sersic(
centre=(1.0, 10), # These are the parameters
ell_comps=(0.5, 0.9), # you need to adjust
ell_comps=(0.5, 0.5), # you need to adjust
intensity=1.0, # to try and improve
effective_radius=1.0, # the model's fit
sersic_index=1.0, # to the data!
Expand Down
2 changes: 1 addition & 1 deletion notebooks/chapter_1_introduction/tutorial_3_fitting.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,7 +1042,7 @@
" redshift=0.5,\n",
" bulge=ag.lp.Sersic(\n",
" centre=(1.0, 10), # These are the parameters\n",
" ell_comps=(0.5, 0.9), # you need to adjust\n",
" ell_comps=(0.5, 0.5), # you need to adjust\n",
" intensity=1.0, # to try and improve\n",
" effective_radius=1.0, # the model's fit\n",
" sersic_index=1.0, # to the data!\n",
Expand Down
2 changes: 1 addition & 1 deletion scripts/chapter_1_introduction/tutorial_3_fitting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@
redshift=0.5,
bulge=ag.lp.Sersic(
centre=(1.0, 10), # These are the parameters
ell_comps=(0.5, 0.9), # you need to adjust
ell_comps=(0.5, 0.5), # you need to adjust
intensity=1.0, # to try and improve
effective_radius=1.0, # the model's fit
sersic_index=1.0, # to the data!
Expand Down
Loading