feat(grids): add respect_small_datasets kwarg to Grid2D.uniform - #327
Merged
Conversation
Lets callers opt out of the PYAUTO_SMALL_DATASETS=1 shape-shrink for grids whose spatial extent is load-bearing (e.g. critical-curve visualizations on cluster-scale lenses). Default `True` preserves existing behaviour.
2 tasks
Collaborator
Author
|
Workspace PR: PyAutoLabs/autolens_workspace_test#109 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
respect_small_datasets: bool = Truekwarg toGrid2D.uniform. WhenPYAUTO_SMALL_DATASETS=1is active, the existing logic silently rewrites any shape larger than 15x15 to(15, 15)atpixel_scales=0.6. Passingrespect_small_datasets=Falseopts out of that shrink for the call.Motivation: a downstream PyAutoGalaxy fix (and an autolens_workspace_test cluster visualization assertion) needs to keep a 100"x100" grid extent in smoke mode to detect a cluster-scale tangential critical curve. The existing shrink defeats every such assertion without changing any of the physics the assertion is meant to detect.
Default behaviour is unchanged — only the explicit opt-out is new.
API Changes
Adds one optional kwarg
respect_small_datasets: bool = Truetoaa.Grid2D.uniform. No removed or renamed symbols; existing callers continue to work without change.See full details below.
Test Plan
pytest test_autoarray/structures/grids/test_uniform_2d.py— all tests pass including the newtest__uniform__small_datasets_env__respect_flag_false__shape_unchanged.autolens_workspace_testunderPYAUTO_SMALL_DATASETS=1recovers the expected critical curve (combined with downstream PyAutoGalaxy fix).Full API Changes (for automation & release notes)
Added
Grid2D.uniform(..., respect_small_datasets: bool = True)— opt-out flag for thePYAUTO_SMALL_DATASETS=1shape-shrink. Default preserves existing behaviour.🤖 Generated with Claude Code