fix: make Array2D.native jit-traceable for JAX simulator path - #339
Merged
Conversation
Replace tuple(native_index_for_slim_index_2d.T) with 2D advanced indexing on the JAX path — the tuple() call iterates the outermost axis of a traced array, triggering TracerArrayConversionError under @jax.jit. Remove the temporary if/else workaround in the imaging simulator and the "jit blocked" docstring caveats. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 25, 2026
Merged
Collaborator
Author
|
Workspace PR: PyAutoLabs/autolens_workspace_test#123 |
Collaborator
Author
|
Workspace PR: PyAutoLabs/autolens_workspace#208 |
Collaborator
Author
|
Workspace PR: PyAutoLabs/autogalaxy_workspace#104 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
array_2d_via_indexes_fromcalledtuple(native_index_for_slim_index_2d.T)on the JAX path, which iterates the outermost axis of a traced array and triggersTracerArrayConversionErrorunder@jax.jit. This was the last structural blocker preventing users from wrappingSimulatorImaging(use_jax=True)andSimulatorInterferometer(use_jax=True)in@jax.jit.Replaced with 2D advanced indexing (
[:, 0], [:, 1]), removed the temporaryif xp is npworkaround in the imaging simulator, and cleaned up the "jit blocked" docstring caveats on both simulators.API Changes
None — internal changes only.
array_2d_via_indexes_fromis a private utility; the simulator public interface is unchanged.Test Plan
simulator_use_jax_parity.py(imaging + interferometer) with@jax.jitroundtrip enabled (workspace follow-up)Full API Changes (for automation & release notes)
Changed Behaviour (internal)
autoarray.structures.arrays.array_2d_util.array_2d_via_indexes_from— JAX path now uses 2D advanced indexing instead oftuple(...T). Semantically identical; now jit-traceable.autoarray.dataset.imaging.simulator.SimulatorImaging.via_image_from— removed theif xp is np: .native else: .arrayguard; always uses.native(now safe under JIT).Removed (docstring caveats only)
SimulatorImaging.__init__docstring: removed "@jax.jit wrapping is currently blocked" noteSimulatorInterferometer.__init__docstring: removed "@jax.jit wrapping is currently blocked" note🤖 Generated with Claude Code