perf: cache expensive @property on Fit classes - #341
Merged
Conversation
FitDataset, FitImaging, and FitInterferometer properties like model_data, residual_map, chi_squared_map, and log_likelihood were recomputing on every access despite depending only on immutable constructor args. For Delaunay inversions model_data alone cost 5-20s — downstream properties accessed it redundantly, creating a cascade of recomputation. Changed @Property to @functools.cached_property. Safe because Fit objects are constructed once and never mutated, and none of these classes use __getstate__ or JAX pytree registration on the Fit object itself. Closes PyAutoArray#340 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes expensive
@propertyto@functools.cached_propertyon FitDataset, FitImaging, and FitInterferometer. These properties (model_data, residual_map, chi_squared_map, log_likelihood, etc.) were recomputing on every access despite depending only on immutable constructor args. For Delaunay inversions,model_dataalone cost 5-20s per access — and downstream properties accessed it redundantly.Closes #340
API Changes
None — same properties, same return types. Now cached after first access.
Test Plan
🤖 Generated with Claude Code