fix: stabilize border relocation for degenerate PCA axes - #446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sqrt(machine epsilon)relative scalePCA eigenvectors are mathematically undefined for equal eigenvalues. NumPy and JAX can choose different valid orientations; deriving maximum ellipse extents along those arbitrary axes made border relocation backend-dependent. The deterministic branch removes that ambiguity without changing the public interface.
Evidence
The downstream full-
FitImagingreproducer measured, before this fix:2.835e-11.492e-18.690e-38.989e-3With this patch applied locally at the worst one-ULP point:
1.583e-161.331e-168.202e-11Validation
jitandvmapround-trips passed with deterministicphi=0API Changes
None. No new configuration or public symbol.
Numerical Behavior
Only near-isotropic border covariances enter the deterministic-axis branch. Non-degenerate PCA behavior and all NNLS settings/algorithms are unchanged.
RED Gate Authorization
The user explicitly instructed this session to continue the work and merge each change once its CI is green. This PR will not be merged unless its own required checks succeed. No release is authorized or performed.
Closes #445