Skip to content

fix: expose valid stored sample pairs - #1470

Merged
Jammy2211 merged 3 commits into
mainfrom
fix/valid-sample-instance-pairs
Aug 11, 2026
Merged

fix: expose valid stored sample pairs#1470
Jammy2211 merged 3 commits into
mainfrom
fix/valid-sample-instance-pairs

Conversation

@Jammy2211

Copy link
Copy Markdown
Collaborator

Closes #1469.

Stage 3 exposed a historical-sample reconstruction gap in the AutoLens aggregator guide. This adds a public Samples.valid_sample_instance_pairs(...) API and delegates the aggregator implementation to it.

  • skips only points rejected by FitException
  • preserves PyAutoGalaxy's parameter guards
  • allows unrelated programming errors to propagate
  • keeps samples, instances, and weights aligned

Verification:

  • full PyAutoFit suite: 1,729 passed, 4 skipped
  • focused regression tests: 25 passed
  • exact failing Stage 3 guide passed against the release candidate wheels with this patch overlaid

Stage 3 run: https://github.com/PyAutoLabs/PyAutoHeart/actions/runs/31525583134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose valid stored sample-instance pairs for guarded historical results

1 participant