Feature/result str - #568
Merged
Merged
Conversation
rhayes777
approved these changes
Jul 29, 2022
| sigma | ||
| The sigma within which the PDF is used to estimate errors (e.g. sigma = 1.0 uses 0.6826 of the PDF).""" | ||
|
|
||
| LINE_LENGTH = conf.instance["general"]["output"]["info_whitespace_length"] |
Collaborator
There was a problem hiding this comment.
Might be worth making a function rather than repeating this
| ) | ||
|
|
||
| assert "Maximum Log Likelihood 1.00000000\n" in result_info | ||
| assert "Maximum Log Likelihood 1.00000000\n" in result_info |
Collaborator
There was a problem hiding this comment.
I wonder if it's worth making this test dynamic
Collaborator
Author
There was a problem hiding this comment.
Don't think so, the config is a tesrt specific one. Worry that dynamic might miss changes to source code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on this PR:
#564
Makes LINE_LENGTH a config file parameter, as users may need different values for optimal display.
Applies to more TextFormatters, so results also use this parameter.