Feature/iterate refactor - #264
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oversampling evaluates a light or mass profile with high precision, where an iterative grid may be used which increases the
sub_sizeuntil a threshold precision is met.This was previously implemented using a
Grid2DIterateobject. However, this led to a lot of code repetition with theGrid2Dobject and an unclear API in terms of how over sampling is performed.This PR removes the
Grid2DIterateobject and moves the functionality into anOverSampleIterateobject, which can be passed into aGrid2Din order to perform iterative oversampling.This also led me to refactor the
datasetpackage, removingSettingsobjects which wrapped theGrid2DIterateobject in awkward ways, cleaning up the code even more!A follow up PR will add a second
OverSampleobject, which performs the normal over sampling which currently occur if theGrid2Ddoes not have anover_sampleobject. This has the bold goal of removing thesub_sizefrom allMaskand data structure objects, would has the potential to make the source code way cleaner. Wish me luck!