mind: file autofit mock all-ones ell_comps bug from the workspace smoke triage - #183
Merged
Merged
Conversation
…ke triage The 2026-08-10 Workspace Smoke ell_comps failures split three ways. Two are resolved: the sampler-draw legs by PyAutoGalaxy#568 (resample invalid profile parameters), and the one genuinely unphysical shipped literal, (0.5, 0.9) in HowToGalaxy tutorial_3_fitting, by a separate workspace fix. The remaining seven aggregator legs across the two *_workspace_test repos fail on ell_comps=(1.0, 1.0), which PyAutoGalaxy#568 does not help because the aggregator rebuilds instances outside any likelihood call. Narrowed to PyAutoFit's mock scaffolding, which fills every parameter with a blanket 1.0 — safe for most parameters, invalid for any ell_comps. The exact call site is not pinned; that needs a real autogalaxy environment. The prompt records the evidence, and records the plausible-but-disproven hypothesis (the scripts' own parameter_list_with_physical_ell_comps helper, which was reproduced against installed autofit and shown to work correctly) so it is not re-tread. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K4jSvqKzCMvqcF4b3wWXFq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Files one new bug prompt from triaging the 2026-08-10 Workspace Smoke
ell_compsfailures, plus the regenerateddashboard.md.draft/bug/autofit/mock_all_ones_parameters_break_ell_comps_guard.mddashboard.md(regenerated withpyauto-brain intake --apply dashboard; backlog 135 → 136)Why
The smoke failures split three ways. Two are already resolved:
guideslegs) — fixed by PyAutoGalaxy#568, which makesModelParameterExceptionaFitExceptionso searches resample instead of terminating.ell_comps=(0.5, 0.9)in HowToGalaxytutorial_3_fitting, corrected in fix: correct unphysical ell_comps in tutorial 3 model-fitting exercise HowToGalaxy#65.The remaining seven aggregator legs across the two
*_workspace_testrepos fail onell_comps=(1.0, 1.0). PyAutoGalaxy#568 does not help there, because the aggregator rebuilds instances from stored samples outside any likelihood call, so there is no resample path. That is what this prompt captures.What the prompt records
Narrowed to PyAutoFit's mock scaffolding, which fills every parameter with a blanket
1.0— a safe placeholder for most parameters and an invalid value for anyell_comps:MockSamples.default_sample_list→kwargs={path: 1.0 for path in self.model.paths}MockSamplesSummary.__init__→self._kwargs = {path: 1.0 for path in self.model.paths}The exact call site is not pinned — closing it needs an environment that can run the full autogalaxy stack, which a cloud session cannot (autoarray/jax/numba will not install). The prompt says so explicitly rather than implying the diagnosis is complete.
It also records a plausible-but-disproven hypothesis so it is not re-tread: the
parameter_list_with_physical_ell_compshelper copy-pasted into all seven scripts looks broken, butell_compsis aTuplePrior, so its path contains a bare'ell_comps'element and the check matches. Reproduced against installed autofit — it yields(0.1, 0.1). Changing that helper would be a no-op.Finally it flags the blast radius (roughly 55 call sites in PyAutoFit alone, plus the PyAutoGalaxy and PyAutoLens suites) so nobody patches shared mock infrastructure without running all three.
Notes
draft/only.active.md,active/andcomplete/are untouched — those belong to$start-dev/$create-issueand the ship skills.lifecycle.py checkreports pre-existing drift (active/pixelized_prodigy_laptop_gpu_phase_1_compatibility.mdhas no registry entry) from an earlier commit. Unrelated to this change and left alone;lifecycle_drift.ymlis path-filtered toactive/**/complete/**, none of which this PR touches.🤖 Generated with Claude Code
Generated by Claude Code