Expand list-valued search qualifiers into repeated chunks#3533
Open
Noethix55555 wants to merge 1 commit into
Open
Expand list-valued search qualifiers into repeated chunks#3533Noethix55555 wants to merge 1 commit into
Noethix55555 wants to merge 1 commit into
Conversation
The six search_* methods built qualifiers with f"{qualifier}:{value}",
so a list/tuple value was serialized as a Python list repr on the wire
(e.g. language:['python', 'ruby']). Expand list/tuple values into
repeated qualifier:value chunks, the GitHub-idiomatic form, via a shared
helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3532
Problem
The six
search_*methods built qualifiers withf"{qualifier}:{value}", so a list/tuple value was serialized as a Python list repr on the wire:Fix
Add a shared
_build_query_qualifiershelper that expands list/tuple values into repeatedqualifier:valuechunks (the GitHub-idiomatic form) and leaves scalar values unchanged. Applied to all six search methods.# q -> "x language:python language:ruby"Multi-word-value quoting is intentionally left unchanged.
Tests
Added offline tests asserting the constructed
qfor list, tuple, and scalar qualifiers. The list/tuple tests fail on HEAD (list repr) and pass with the fix; the scalar test is unchanged behavior.