Bumped ndarray to 0.17. - #516
Conversation
|
Thank you! Could you also add a changelog entry please? |
I have created an entry for |
|
Just curious, but when is this change shipped to crates.io? |
|
Generally there is a release when a new PyO3 major version ships. PyO3 0.28 is loosely targeted around end of the year. But it looks like there is some interest in this getting shipped, so I can see if I get to prepare a patch release sooner. |
This is a breaking change so you might need to make a breaking release of |
|
I should not be breaking, we just extended the supported range of |
|
Ah, apologies! I didn't look closely enough to see that it didn't force users to use ndarray 0.17 |
|
No worries |
|
We are also waiting for ndarray 0.17 support to rust-numpy to move forward with other crates |
|
Done in #517, should be live now 🎉 |
|
I'm not familiar enough with cargo's dependency resolver to be able to tell why this fails exactly, but this change did in fact break our code that depends on ndarray and numpy. The numpy dependency wants to pull ndarray 0.17 whereas our code was still on ndarray 0.16. Do you know a way to avoid numpy picking 0.17 so that we don't encounter these problems in the future? |
|
That is unfortunate, sorry about that. Maybe we should considers these as breaking in the future 🤔 |
Previously the version constraint was updated to ndarray <= 0.17 but the 0.17 release was yanked and this excludes 0.17.1 and later point releases. This updates the dependency specification to < 0.18 which will allow point releass (and which is closer to what was used before PyO3#516).
6 participants
Bumped ndarray to 0.17.