BLD: switch to using Meson as the build system for PyWavelets#667
Merged
Conversation
rgommers
force-pushed
the
meson
branch
6 times, most recently
from
7c7a13b to
5da4643
Compare
Also stop using editable installs, there is no need for those.
[skip actions]
[build wheel]
Member
Author
|
@grlee77 this should be good to go now - I also tested the |
This was referenced Mar 29, 2023
grlee77
approved these changes
Apr 3, 2023
grlee77
left a comment
grlee77
left a comment
Contributor
There was a problem hiding this comment.
Thanks for doing this @rgommers! I did also verify locally that plain pip install . as recommended in our README works from this branch.
Thanks for providing the context on editable builds. It is great to know that will also work soon.
Member
Author
|
Thanks for the review Greg. Okay, let's give it a go then:) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is using editable builds, which should work better with meson-python 0.13.0 (expected next week). I tested that locally and it works smoothly. Build time is down to ~10 seconds, and build log is clean.
Closes gh-621