fix: prevent mixed =/- chars in Setext-style headings (fixes #1604)#1605
Open
Jah-yee wants to merge 1 commit into
Open
fix: prevent mixed =/- chars in Setext-style headings (fixes #1604)#1605Jah-yee wants to merge 1 commit into
Jah-yee wants to merge 1 commit into
Conversation
The regex [=-]+ incorrectly matches mixed runs like '=-' or '-=' which are not valid Setext headers (only = or - alone are valid). Fix using (?:[=]+|[-]+) to match only homogeneous runs. Fixes issue Python-Markdown#1604
Collaborator
|
There should be tests added for previously failing cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The regex
[=-]+incorrectly matches mixed runs like=-=-or-=-=as Setext-style headings, even though only all-=(H1) or all--(H2) are valid.Fix
Changed regex from
[=-]+to(?:[=]+|[-]+).Test
Fixes #1604