Skip to content

[dm][ufs] fixup the ufs supported - #11646

Open
GuEe-GUI wants to merge 2 commits into
RT-Thread:masterfrom
GuEe-GUI:ufs
Open

[dm][ufs] fixup the ufs supported#11646
GuEe-GUI wants to merge 2 commits into
RT-Thread:masterfrom
GuEe-GUI:ufs

Conversation

@GuEe-GUI

@GuEe-GUI GuEe-GUI commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

拉取/合并请求描述：(PR description)

[

  1. add 4K support for EFI partion for UFS
  2. fixup the linkup flow

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用clang-format 源码格式化工具确保格式符合RT-Thread代码规范 This PR has been formatted with clang-format and complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

GuEe-GUI added 2 commits July 22, 2026 23:01
@GuEe-GUI
[dm][block] add 4K support for EFI partion
cc0d52b 
Signed-off-by: GuEe-GUI <2991707448@qq.com>
@GuEe-GUI
[dm][ufs] fixup the linkup flow
ab4348e 
Signed-off-by: GuEe-GUI <2991707448@qq.com>
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：ufs
  • 设置PR number为 \ Set the PR number to：11646
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 ufs 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the ufs branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/drivers/block/partitions/efi.c
  • components/drivers/include/drivers/ufs.h
  • components/drivers/ufs/ufs.c
  • components/drivers/ufs/ufs_pm.c

📊 Current Review Status (Last Updated: 2026-07-22 23:27 CST)

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

MemBrowse Memory Report

k230

  • SRAM: .eh_frame +152 B (+0.0%, 1,122,835 B / 268,300,288 B, total: 0% used)

nuvoton-m487

  • CODE: .text +296 B (+0.1%, 356,108 B / 524,288 B, total: 68% used)

qemu-virt64-aarch64

@GuEe-GUI

GuEe-GUI commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

@Rbb666

@Rbb666
Rbb666 requested a review from Copilot August 3, 2026 02:28
Copilot AI reviewed Aug 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Not ready to approve

It introduces a confirmed GPT size validation regression (potential out-of-bounds CRC read) and a confirmed ISR/thread race on irq_status that can drop interrupt bits.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

This PR improves UFS bring-up robustness and extends EFI/GPT partition parsing to support disks with 4KB logical block sizes (common on UFS), aligning the driver stack with early-probe and non-512B sector environments.
本 PR 增强了 UFS 初始化/链路启动流程的健壮性，并扩展 EFI/GPT 分区解析以支持 4KB 逻辑块大小（UFS 常见），以适配早期 probe 阶段及非 512B 扇区的场景。

Changes:

  • UFS: Add HCE enable wait, refactor link-startup flow, and switch UTP completion wait to polling for early-probe hosts.
    UFS：增加 HCE 使能等待、调整链路启动流程，并将 UTP 完成等待改为轮询以适配早期 probe 主机。
  • UFS PM: Add UIC DME_RESET / DME_ENABLE helper APIs.
    UFS 电源管理：新增 UIC DME_RESET / DME_ENABLE 辅助接口。
  • EFI/GPT: Make GPT reads work with logical block sizes > 512B (e.g., 4KB).
    EFI/GPT：支持逻辑块大小大于 512B（如 4KB）的读取与解析。
File summaries
File Description
components/drivers/ufs/ufs.c Adds early bring-up waits/polling and updates link/transfer flow for more robust UFS initialization.
components/drivers/ufs/ufs_pm.c Introduces new DME reset/enable helpers wrapping UIC commands with result checking.
components/drivers/include/drivers/ufs.h Extends rt_ufs_ops with hce_enable_notify and exports new DME helper APIs.
components/drivers/block/partitions/efi.c Updates GPT/EFI reading logic to support 4KB logical blocks and improves error handling.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 3
  • Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Comment thread components/drivers/block/partitions/efi.c
Comment on lines 498 to 502
/* Sanity check partition table size */
pt_size = (rt_uint64_t)rt_le32_to_cpu((*gpt)->num_partition_entries) *
rt_le32_to_cpu((*gpt)->sizeof_partition_entry);

if (pt_size > (rt_uint64_t)RT_UINT32_MAX)
{
goto _fail;
}

if (!(*ptes = alloc_read_gpt_entries(disk, *gpt)))
Comment thread components/drivers/ufs/ufs.c
Comment on lines +409 to +412
LOG_E("%s: UFS UTP wait timeout: IS=%#08x irq_status=%#08x UTRLDBR=%#08x OCS=%#x",
rt_dm_dev_get_name(ufs->parent.dev),
HWREG32(regs + RT_UFS_REG_IS), ufs->irq_status);
HWREG32(regs + RT_UFS_REG_IS), ufs->irq_status,
HWREG32(regs + RT_UFS_REG_UTRLDBR), ufs_utrd_ocs(ufs));
Comment thread components/drivers/ufs/ufs.c
Comment on lines +93 to +95
ufs->irq_status &= ~RT_UFS_REG_IS_UTRCS;
HWREG32(ufs->regs + RT_UFS_REG_IS) = RT_UFS_REG_IS_UTRCS;
return RT_EOK;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

component: drivers Component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GuEe-GUI