test: Fix several flaky tests - #10388
Merged
Merged
Conversation
lizschwab
approved these changes
Aug 28, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR resolves various leaked state and potentially invalid assertions in the test suite that could cause flakes. These were identified with LLM assistance and manually reviewed. The shortcut items test was flaky, but it was best resolved by using the real focus manager instead of a stub, so the changes there are more extensive but also make the test more robust. I did remove two tests from it that weren't doing anything useful, for Page Up/Down in a flyout; since child blocks can't be focused in a flyout, you can't set up a scenario to test that they don't attempt to focus the root/end of the stack, and as the comment used to note, assertions about what they do do are tested elsewhere.