This repository was archived by the owner on May 15, 2026. It is now read-only.
feat: improve 'no tools used' error handling with grace retry - #10196
Merged
Conversation
- Add consecutiveNoToolUseCount to track consecutive no-tool-use errors - Only show error and count toward mistake limit after 2 consecutive failures - Reset counter on successful tool use or manual abort - Display user-friendly error messages with clear explanations in ChatRow - Remove Gemini placeholder text emission for reasoning without content - Add localized strings for model response errors in all 18 locales
Re-review complete. Previous issues appear resolved in the latest commit(s).
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.</sub> |
ghost
reviewed
Dec 18, 2025
ghost
reviewed
Dec 18, 2025
cte
approved these changes
Dec 18, 2025
…ble incrementing - Remove duplicate 'error' keys from 13 locale chat.json files (ca, de, es, fr, hi, it, ja, ko, pl, pt-BR, tr, vi, zh-CN) - Remove redundant consecutiveMistakeCount++ from initiateTaskLoop() - now handled solely by grace-retry logic in recursivelyMakeClineRequests()
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
ghost
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the user experience when models fail to use tools by implementing a grace retry mechanism and displaying clearer, more informative error messages.
After the first instance of no tools being returned it simply retries without informing the user as this is "normal" behaviour from time to time.
After 2 consecutive responses without tools the user sees this.
After repeated attempts (based on the error retry logic/setting, default 3) the user will see this
Changes
consecutiveNoToolUseCountcounter in Task.ts to track consecutive "no tools used" errorsmodelResponseErrorsstrings in all 18 locale files (ca, de, en, es, fr, hi, id, it, ja, ko, nl, pl, pt-BR, ru, tr, vi, zh-CN, zh-TW)Important
Enhances 'no tools used' error handling with a grace retry mechanism and improved user messaging, including localization updates.
consecutiveNoToolUseCountinTask.tsto track consecutive 'no tools used' errors.ChatRow.tsxwith detailed explanations.gemini.ts.ChatRow.tsxto handle and display specific error messages for 'no tools used'.modelResponseErrorsstrings to 18 locale files (e.g.,ca/chat.json,de/chat.json,en/chat.json).This description was created by
for 3cdf701. You can customize this summary. It will automatically update as commits are pushed.