Revert "feat: syntax highlighting terminal output with Shiki"#3023
Conversation
This reverts commit 8b072ad.
|
|
thanks for the heads up. I wonder why it worked for me... |
or maybe it didn't work and CTRL+SHIFT+F5 silently failed? Anyway I'll fix it up unless you get to it first. Thanks for all the work on execa and shiki merging! |
I ran into issues where it continued to work until I force quit vite and restarted the server. |
|
tests passed, so any ideas on a test to prevent this type of issue? |
|
also: did you find a useful backtrace or error that pointed at the issue? |
Uncaught TypeError: (0 , util_1.promisify) is not a function
at ../node_modules/isbinaryfile/lib/index.js (isbinaryfile.js?v=2af49b69:29:42)
at __require2 (chunk-ONY6HBPH.js?v=2af49b69:26:50)
at isbinaryfile.js?v=2af49b69:223:16I think that was it, but its not a very friendly error... working on moving related string processing/truncation fn's to shared... |
Reverts #3021
CC @KJ7LNW - This is breaking the webview; specifically the import of the BaseTerminal here. It's generally not safe to import from anything except
src/shared.Important
Reverts syntax highlighting feature in
CommandExecution.tsx, removingBaseTerminalandCodeBlockusage, and updates related tests.CommandExecution.tsx.BaseTerminalandCodeBlockinCommandExecution.tsx.CommandExecutionnow usesVirtuosofor output rendering instead ofCodeBlock.CommandExecution.test.tsxto mockVirtuosoandChevronDown.CodeBlockand updates tests to check forVirtuosorendering.This description was created by
for 06f149f. You can customize this summary. It will automatically update as commits are pushed.