Skip to content
This repository was archived by the owner on May 15, 2026. It is now read-only.

Revert "feat: syntax highlighting terminal output with Shiki"#3023

Merged
cte merged 1 commit into
mainfrom
revert-3021-feat-terminal-syntax-highlighting
Apr 29, 2025
Merged

Revert "feat: syntax highlighting terminal output with Shiki"#3023
cte merged 1 commit into
mainfrom
revert-3021-feat-terminal-syntax-highlighting

Conversation

@cte

@cte cte commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

Reverts #3021

CC @KJ7LNW - This is breaking the webview; specifically the import of the BaseTerminal here. It's generally not safe to import from anything except src/shared.


Important

Reverts syntax highlighting feature in CommandExecution.tsx, removing BaseTerminal and CodeBlock usage, and updates related tests.

  • Revert Changes:
    • Reverts syntax highlighting feature using Shiki in CommandExecution.tsx.
    • Removes import of BaseTerminal and CodeBlock in CommandExecution.tsx.
  • Component Updates:
    • CommandExecution now uses Virtuoso for output rendering instead of CodeBlock.
    • Removes terminal output compression logic.
  • Testing:
    • Updates CommandExecution.test.tsx to mock Virtuoso and ChevronDown.
    • Removes tests related to CodeBlock and updates tests to check for Virtuoso rendering.

This description was created by Ellipsis for 06f149f. You can customize this summary. It will automatically update as commits are pushed.

@changeset-bot

changeset-bot Bot commented Apr 29, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 06f149f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 29, 2025
@cte cte merged commit 60270d1 into main Apr 29, 2025
6 of 7 checks passed
@cte cte deleted the revert-3021-feat-terminal-syntax-highlighting branch April 29, 2025 06:08
@github-project-automation github-project-automation Bot moved this from New to Done in Roo Code Roadmap Apr 29, 2025
@KJ7LNW

KJ7LNW commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

thanks for the heads up. I wonder why it worked for me...

@KJ7LNW

KJ7LNW commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

thanks for the heads up. I wonder why it worked for me...

or maybe it didn't work and CTRL+SHIFT+F5 silently failed?

Anyway I'll fix it up unless you get to it first.

Thanks for all the work on execa and shiki merging!

@cte

cte commented Apr 29, 2025

Copy link
Copy Markdown
Contributor Author

thanks for the heads up. I wonder why it worked for me...

or maybe it didn't work and CTRL+SHIFT+F5 silently failed?

I ran into issues where it continued to work until I force quit vite and restarted the server.

@KJ7LNW

KJ7LNW commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

tests passed, so any ideas on a test to prevent this type of issue?

@KJ7LNW

KJ7LNW commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

also: did you find a useful backtrace or error that pointed at the issue?

@KJ7LNW

KJ7LNW commented Apr 29, 2025

Copy link
Copy Markdown
Contributor
Uncaught TypeError: (0 , util_1.promisify) is not a function
    at ../node_modules/isbinaryfile/lib/index.js (isbinaryfile.js?v=2af49b69:29:42)
    at __require2 (chunk-ONY6HBPH.js?v=2af49b69:26:50)
    at isbinaryfile.js?v=2af49b69:223:16

I think that was it, but its not a very friendly error...

working on moving related string processing/truncation fn's to shared...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants