Terminal performance improvements#3119
Conversation
|
dosubot
Bot
added
size:L
| this.startHotTimer(line) | ||
| } | ||
|
|
||
| if (this.aborted) { |
There was a problem hiding this comment.
We now stop processing the terminal output when an abort signal is received. If the abort signal can't kill the process then we manually kill it.
| }) | ||
| } | ||
|
|
||
| export const splitCommandOutput = (text: string) => { |
There was a problem hiding this comment.
This was expensive to run when there's lot of terminal output. I don't think it provided enough value to justify the performance hit.
1 participant
Context
It's very expensive to trigger
postStateToWebViewcalls due to the serialization involved. Noisy terminal will trigger this due to thecline.say("command_output", ...)calls.It's much faster to just send an event containing only the new output rather than full state updates.
In testing this was a huge performance win.
Important
Optimize terminal performance by sending incremental command outputs and updating related schemas and UI components.
executeCommandTool.ts.ExecaTerminalProcess.tsto handle command abortion and output streaming more efficiently.commandExecutionStatusSchemainschemas/index.tsto includestarted,output,exited, andfallbackstatuses.CommandExecutioninCommandExecution.tsxto handle new command execution statuses and display outputs incrementally.ChatRow.tsxto integrate with the new command execution flow and display.This description was created by
for 062c89c. You can customize this summary. It will automatically update as commits are pushed.