You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 15, 2026. It is now read-only.
Using a noisy terminal command I was able to get Roo into a state where it was performing extremely poorly due to excessive calls to postStateToWebview. When I profiled the app a few things stood out, but this was the lowest hanging fruit. The getCustomModes call is slow, and we were calling it twice in row instead of just using the first result.
Important
Improve CustomModesManager performance by implementing caching for getCustomModes() with cache invalidation and TTL handling.
Performance Improvements:
Implement caching in CustomModesManager for getCustomModes() with a TTL of 10 seconds to reduce redundant file reads.
Cache is invalidated on mode updates, deletions, and after TTL expiration.
Code Changes:
Add cachedModes and cachedAt properties to CustomModesManager.
Add clearCache() method to CustomModesManager to handle cache invalidation.
Refactor getCustomModes() to utilize caching logic.
Tests:
Add tests in CustomModesManager.test.ts to verify caching behavior, including cache invalidation on updates and deletions, and TTL expiration.
Miscellaneous:
Minor refactoring in CustomModesManager.ts for code clarity.
Update ClineProvider.ts to use cached customModes in postStateToWebview().
This description was created by for 431d4c0. You can customize this summary. It will automatically update as commits are pushed.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
You think it might be a good idea to establish a pattern eventually for new contributors to follow for "streamy or chunky" large volume flow like..... a RooQueue? <runs_away/>
edit. Or does TS have a popular Reactive framework that isn't too weird for devs to pickup? Pub / Sub sometimes turns people off with all the higher-order function stuff like Zip and Merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Using a noisy terminal command I was able to get Roo into a state where it was performing extremely poorly due to excessive calls to
postStateToWebview. When I profiled the app a few things stood out, but this was the lowest hanging fruit. ThegetCustomModescall is slow, and we were calling it twice in row instead of just using the first result.Important
Improve
CustomModesManagerperformance by implementing caching forgetCustomModes()with cache invalidation and TTL handling.CustomModesManagerforgetCustomModes()with a TTL of 10 seconds to reduce redundant file reads.cachedModesandcachedAtproperties toCustomModesManager.clearCache()method toCustomModesManagerto handle cache invalidation.getCustomModes()to utilize caching logic.CustomModesManager.test.tsto verify caching behavior, including cache invalidation on updates and deletions, and TTL expiration.CustomModesManager.tsfor code clarity.ClineProvider.tsto use cachedcustomModesinpostStateToWebview().This description was created by
for 431d4c0. You can customize this summary. It will automatically update as commits are pushed.