syscall: explain untrusted symlink refusal - #1074
Merged
steadytao merged 2 commits intoSep 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1067
Summary
Explain when rsync rejects an operator path because a symlink component is owned by an untrusted user.
The existing
ELOOPresult and security policy remain unchanged. The additional diagnostic identifies the ownership rule and points operators to the local and daemon-specific compatibility controls while warning that every path component must be trusted.The existing cross-UID destination regression now asserts the non-zero exit and actionable diagnostic as well as proving that no files are written through the attacker-owned symlink.