Skip to content

syscall: follow trusted sender ancestor links - #1088

Open
steadytao wants to merge 3 commits into
masterfrom
sender-ancestor-links
Open

steadytao wants to merge 3 commits into
masterfrom
sender-ancestor-links

Conversation

@steadytao

@steadytao steadytao commented Sep 14, 2026

Copy link
Copy Markdown
Member

Fixes #1087

Summary

Explicit sender directory arguments now act as transfer roots and may pass through symlinks regardless of ownership. This fixes both absolute and relative source paths, including --relative while keeping recursive traversal confined beneath the selected source root.

Daemon paths, --files-from entries and file-leaf symlink handling are unchanged.

@steadytao

Copy link
Copy Markdown
Member Author

@peabee Could you test this with your backup application using the original /mnt/home/My_Documents path? Please check that the backup completes and the expected files are copied.

@steadytao steadytao added the bug Something isn't working label Sep 14, 2026
@peabee

peabee commented Sep 14, 2026

Copy link
Copy Markdown

Hi happy to test but unsure what "this" is or how to obtain it......
A binary would be ideal......
But if you want me to download source and compile I don't know how to download source with a pull request included - sorry!

@steadytao

Copy link
Copy Markdown
Member Author

This is built against TrixiePup64, so it may not run on your Slackware-based Puppy - rsync.tar.gz

Make sure to keep your existing rsync; if this binary reports a library error, send me that error and your exact Puppy version/environment so I can provide a matching build.

@steadytao

Copy link
Copy Markdown
Member Author

Ah and you can use git clone --single-branch --branch sender-ancestor-links https://github.com/RsyncProject/rsync.git to clone the PR if that is easier.

Comment thread syscall.c Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sender-side ELOOP after upgrading to 3.5.0

3 participants