Create the X11 window with a depth of 32-bits#114
Closed
robbert-vdh wants to merge 1 commit into
Closed
Conversation
This should fix the inability to create OpenGL contexts with alpha channels in raw-gl-context, but it seems like that still needs a bit more work.
Member
Author
|
I'll close this since this does not solve any problems and it triggers the same mismatching visual problem with Mesa (which just happens to work with the first visual by coincidence). I'll open a new PR after I integrated raw-gl-context back into baseview. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was supposed to fix micahrj/raw-gl-context#2, but it seems like setting the correct visual wasn't the magic bullet. Still, having the windows created with a 32-bit visual seems like a good idea since almost everything does that and now you can rely on the baseview window always having the same depth instead of it being dependent on the parent window.