Allow taking ownership of the OpenGL context#120
Closed
robbert-vdh wants to merge 1 commit into
Closed
Conversation
This is needed for certain GUI integrations that require moving the context into something that's `Send + Sync + 'static`.
Member
Author
|
Since this allows the context to outlive the window this isn't a great solution. We'll need to find a different way to make |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #115. Having the window own the context seemed like a sensible approach to me since there's an
on_frame()callback where you'd do your rendering, but some integrations like @BillyDM's iced_baseview do the rendering from a separateSend + Sync + 'staticcontext, and you thus need to be able to move the OpenGL context into there. This change means that you'll need to move theGlContextinto your window handle struct when first creating it by callingwindow.gl_context().take().