Various refactorings#269
Merged
Merged
Conversation
advantages: (1) more reliable copy paste, (2) authors see more clearly that something is missing, (3) adding dual properties is encouraged more, (4) files become more similar
as with the other adjustments, this ensures consistency and motivates to add the left adjoint in case it exists
This was referenced Jul 6, 2026
dschepler
added a commit
to dschepler/CatDat
that referenced
this pull request
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains various refactorings, most of which were already indicated by TODO comments in the code.
related_categories→related,related_properties→related,dual_category→dual, anddual_property→dual. This reduces the amount of typing required and also allowed the seed types to be improved. Because of this change, this PR has touched hundreds of YAML files, but only in a trivial way.nlab_linkanddual_propertyare now required, but may benull. (It was inconsistent before if they can be missing ornull.) This makes missing data more visible and encourages it to be filled in. The same applies toleft_adjoint(although it must of course benullfor some functors). Overall, the files are now more consistent, and the seed types have been improved accordingly.''is no longer allowed. Instead, the relation"preserves"is used for preservation properties. In property lists, this relation (or its negation, depending on the context) is displayed, while the"preserves "prefix is stripped from the property name.terminal object => filtered, which has been obsolete since Add property: ℵ₁-cofiltered limits #200. It was only needed briefly whilealeph1-filteredexisted butaleph1-cofiltereddid not, causing dualization to fail.