chore(rsc-runtime): drop the react-server-components keyword - #106
Merged
Conversation
The published manifest contradicted itself: #89 rewrote the description to say the package is a React-element result DSL and explicitly not an RSC renderer, while the keywords array kept claiming react-server-components. Keeps the honest keywords (agent-bundle, mcp); the package name is out of scope here.
🦋 Changeset detectedLatest commit: 18a1393 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/rsc-runtime/package.jsoncontradicted itself. #89 rewrote thedescriptionin that file to state that the package is a React-element result DSL (an "MCP result DSL") and explicitly not a React Server Components renderer or Flight transport, but leftreact-server-componentssitting in thekeywordsarray of the same manifest. This drops that keyword so the published metadata agrees with itself and the registry stops surfacing the package against RSC-renderer searches it cannot serve.Keywords kept:
agent-bundle,mcp— both accurate. No other keyword in the array overclaims (there is norsc,flight, orserver-componentsentry).Scope is deliberately narrow: no rename. The package name
@agent-bundle/rsc-runtimeis untouched and remains tracked in #78. Likewise, #96 proposes building a real RSC/Flight renderer later; this change describes the package as it exists today and does not prejudge that work.Pins
No test pins the rsc-runtime keywords array. The only keywords assertion in the suite is in
packages/agent-bundle/tests/release-audit.test.ts, and it covers theagent-bundleproduct manifest, not this package. Nothing needed updating.Test plan
Metadata-only change, gated with the
--current-node-onlylocal-ci leg plus the packed release-audit metadata tests:pnpm check:local-ci --current-node-only— GREEN (build,lint:package,typecheck,lint,test:unit1781/1785 passed 4 skipped,test:integration556/558 passed 2 skipped)node scripts/run-packed-tests.mjs --release packages/agent-bundle/tests/release-audit.test.ts— 4/4 passed, including "ships repository and support metadata that matches the verified origin"publint packages/rsc-runtime— All goodPatch changeset included for
@agent-bundle/rsc-runtime(published metadata change).