chore: deslop pass over the wave 1 delta - #137
Merged
Merged
Conversation
Apply the post-merge-tier findings from the orchestrated audit (issue #107 ledger) plus one fresh-scan cleanup, behavior unchanged: - config/normalize.ts imports the shared core/freeze.ts deepFreeze instead of carrying the local copy the route compiler already dropped. - routes/graph.ts stops exporting configClaimedSources; nothing outside the module consumes it. - rsc-runtime cli.ts drops the redundant Object.freeze around capabilities (runAgentRequest snapshots and freezes them). - rsc-runtime README lists the exported available/unavailable helpers. - The "Pin flip" change-narration comment prefixes become durable explanations of why workspace-rooted fixtures expect AB4008. - rstest.worker-isolation.ts uses process.env like the rest of the file. - dev-lock.ts settles the URL publication through one named cleanup instead of two identical inline then-arms. Scoped tests for every touched file, typecheck, and rslint are green.
🦋 Changeset detectedLatest commit: f729875 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies the post-merge-tier findings from the orchestrated deslop audit (ledgered on #107) plus one fresh-scan cleanup from tonight's unaudited merges. Behavior unchanged; −11 net lines.
config/normalize.tsimports the sharedcore/freeze.tsdeepFreezeinstead of its local copy (the route compiler's copy was already migrated by the feat: compile route-graph IR and inspect focus (#93) #119 lander; this removes the last duplicate).routes/graph.tsstops exportingconfigClaimedSources— still unconsumed outside the module after feat: statically extract route config exports into the route-graph IR (#93, PR-2) #135.cli.tsdrops the redundantObject.freezearound capabilities (runAgentRequestsnapshots and freezes them), and the README export list now includesavailable/unavailable.rstest.worker-isolation.tsusesprocess.envconsistently with the rest of the file.dev-lock.tssettling the URL publication through one named cleanup instead of two identical inline then-arms (.then(f, f)retained deliberately —.finallywould re-reject the voided chain).Deliberately skipped (behavior-adjacent, noted for later lanes): consolidating the triple
snapshotPackageIdentityread per prepare, comparing the torn-prepare check against the snapshot's own recorded config hash, and thepreparedProjectoptions-object conversion (assigned to the next signature-touching lane).Test plan
pnpm typecheckgreenpnpm lintgreen (686 files)