Skip to content

feat(claude): emit LSP server configs (.lsp.json) - #157

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
fix/155-claude-lsp
Sep 1, 2026
Merged

feat(claude): emit LSP server configs (.lsp.json)#157
ScriptedAlchemy merged 1 commit into
mainfrom
fix/155-claude-lsp

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

  • add typed claude.lspServers source configuration and emit a validated plugin-root .lsp.json for Claude targets
  • preserve conventional discovery without a manifest pointer, reject duplicate extension claims, and limit path-token expansion to command, args, env, and workspaceFolder
  • keep Codex and the composite capability honestly unavailable while still emitting the Claude document from the shared plugin root

Design and provenance

  • pins the Claude Code 2.1.250 LSP contract, including string | array | object manifest forms and the standalone schema's required and optional fields
  • records the official Claude Code plugin documentation provenance, binary-install requirement, first-registered extension behavior, and supported token fields
  • keeps this consumer-driven surface host-scoped; the portable cross-host LSP component kind remains deferred under Compile capability-aware host component bundles #100

Test plan

  • scoped adapter, schema, normalization, composite, capability, and metadata tests
  • workspace typecheck
  • workspace lint

Fixes #155

Add a host-scoped Claude LSP surface while preserving honest composite capability reporting and conventional plugin-root discovery.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T17:00:58.006844Z 42da2ae PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@changeset-bot

changeset-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 42da2ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
agent-bundle Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ScriptedAlchemy
ScriptedAlchemy merged commit 7379552 into main Sep 1, 2026
2 of 9 checks passed
@ScriptedAlchemy
ScriptedAlchemy deleted the fix/155-claude-lsp branch September 1, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Claude plugin adapter does not emit LSP servers (.lsp.json / lspServers)

1 participant