feat(dev): add the dev-seam Effect boundary module (wave 3.5 stage 3, PR 1) - #158
Conversation
🦋 Changeset detectedLatest commit: c7eefc4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7eefc4fec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
First PR of #152 stage 3 (dev seam). No behavior change — foundation only.
packages/agent-bundle/src/effect/boundary.ts: the package's sole Effect → Promise/sync edge, mirroringpackages/rsc-runtime/src/effect/boundary.ts(runPromise/runPromiseExit/runSync/runSyncExit,makeScopedEffectRuntime,interruptWhenAborted,scopedAbortSignal). Error mapping targets the dev seam's typed contracts: interruption →DOMExceptionAbortError;CodedErrorsubclasses, coded-shape errors (EpochStoreError), and the AB diagnostic carrierDiagnosticErrorrethrow unchanged.effect@4.0.0-rc.112(exact, same pin as the runtime package) added topackages/agent-bundledependencies. Nothing imports the boundary yet, so no dist entry changes.packages/agent-bundle/src/effect/boundary.tsis the only legal runner home in this package and that ad-hoc runners in dev-seam files are review-fails (the rule itself already matched anysrc/effect/boundary.ts).docs/effect-conventions.mdboundary-module row updated.Parity / gates
pnpm lint(764 files): greenpnpm typecheck: greenRefs #152.