Skip to content

feat(dev): add the dev-seam Effect boundary module (wave 3.5 stage 3, PR 1) - #158

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
wave35-s3/boundary
Sep 1, 2026
Merged

feat(dev): add the dev-seam Effect boundary module (wave 3.5 stage 3, PR 1)#158
ScriptedAlchemy merged 1 commit into
mainfrom
wave35-s3/boundary

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

First PR of #152 stage 3 (dev seam). No behavior change — foundation only.

  • packages/agent-bundle/src/effect/boundary.ts: the package's sole Effect → Promise/sync edge, mirroring packages/rsc-runtime/src/effect/boundary.ts (runPromise/runPromiseExit/runSync/runSyncExit, makeScopedEffectRuntime, interruptWhenAborted, scopedAbortSignal). Error mapping targets the dev seam's typed contracts: interruption → DOMException AbortError; CodedError subclasses, coded-shape errors (EpochStoreError), and the AB diagnostic carrier DiagnosticError rethrow unchanged.
  • effect@4.0.0-rc.112 (exact, same pin as the runtime package) added to packages/agent-bundle dependencies. Nothing imports the boundary yet, so no dist entry changes.
  • feat(runtime): Effect v4 foundation — vendored source, boundary module, conventions (#wave 3.5 stage 0) #153 boundary-lint coverage extended: lint tests now pin that packages/agent-bundle/src/effect/boundary.ts is the only legal runner home in this package and that ad-hoc runners in dev-seam files are review-fails (the rule itself already matched any src/effect/boundary.ts).
  • docs/effect-conventions.md boundary-module row updated.
  • Changeset: patch (internal only).

Parity / gates

  • New boundary tests + lint-rule tests: green
  • pnpm lint (764 files): green
  • pnpm typecheck: green

Refs #152.

@changeset-bot

changeset-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c7eefc4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
agent-bundle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ScriptedAlchemy
ScriptedAlchemy merged commit 70deb99 into main Sep 1, 2026
4 of 9 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T17:21:58.464514Z c7eefc4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c7eefc4fec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/agent-bundle/src/effect/boundary.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant