Skip to content

fix(dev): recheck cancellation after epoch probe (review follow-up #134) - #163

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
fix/review-134
Sep 1, 2026
Merged

fix(dev): recheck cancellation after epoch probe (review follow-up #134)#163
ScriptedAlchemy merged 1 commit into
mainfrom
fix/review-134

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

  • recheck the caller abort signal after the asynchronous epoch availability probe and before MCP tool dispatch
  • add a deterministic regression covering cancellation while the epoch probe is pending

Test plan

  • pnpm exec rstest run packages/agent-bundle/tests/mcp-session-service.test.ts --config rstest.integration.config.ts
  • pnpm typecheck
  • pnpm lint

@changeset-bot

changeset-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f23477c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T18:07:50.380683Z f23477c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ScriptedAlchemy
ScriptedAlchemy merged commit 8cd9791 into main Sep 1, 2026
4 of 9 checks passed
@ScriptedAlchemy
ScriptedAlchemy deleted the fix/review-134 branch September 1, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant