fix(tooling): review follow-ups from #146/#148/#162 - #166
Conversation
Keep concurrent example checks portable and adequately budgeted, retain fast cleanup coverage in PR gates, and document Semaphore ordering accurately.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
…me it (#174) The audiobook-curator package build's d.ts generation (rslib environment agent-bundle-index) failed with TS4023 on every exported operations factory: their inferred return types reference CliCommandDefinition, which #150 introduced unexported. Declaration emit must import the type from src/cli-command, so `agent-bundle build` failed with AB5000 ("Error occurred in agent-bundle-index declaration files generation.") while `tsc --noEmit` passed. Reported during examples:check in #166's report.
1 participant
Summary
AGENT_BUNDLE_TEST_TIME_SCALEat 2Test plan
pnpm typecheckpnpm lintAGENT_BUNDLE_TEST_TIME_SCALE=1 pnpm examples:check(wrapper launched the 3-way run; existing Audiobook Curator declaration generation failed with AB5000, also reproducible in its standalone build)