fix(test): honest registry version gate, binary-faithful CLI cwd, README field - #206
Merged
Conversation
…DME field Post-merge review findings from #190: bump AGENT_TEST_REGISTRY_VERSION to 2 so registries missing the required cliCommands/plugin manifest fields fail the existing version gate with a recoverable AgentTestError instead of crashing inside invokeCli or the MCP helpers; derive the invokeCli request workspace from process.cwd() to match the generated executable's semantics instead of manifest.projectRoot; correct the README example to read call.structuredContent (the McpToolInvocation field) rather than call.result.
🦋 Changeset detectedLatest commit: 4294388 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the three unaddressed Codex post-merge findings on #190:
src/test/registry.ts, flagged at manifest.ts:104) —AGENT_TEST_REGISTRY_VERSIONstayed 1 while feat(test): projection-contract proof levels for the consumer harness (#103 stage 2) #190 added requiredcliCommands/pluginmanifest fields, so mixed-version installs passed the version gate and crashed later ininvokeCli/MCP helpers. Bumped to 2; stale registries now fail the existing gate with the recoverableAgentTestError("found 1, expected 2" + install-one-version recovery) before any helper reads missing fields.src/test/cli.ts:193) —invokeCliresolved the request workspace frommanifest.projectRoot, but the generated binary resolves fromprocess.cwd()(verified inentry-shell.tsgenerated code). The harness now matches the shipped artifact.README.md:235) — example readcall.result.structuredContent; the realMcpToolInvocationfield iscall.structuredContent.Tests
Regression tests: version-1 registry refusal with the honest error (
test-harness-manifest.test.ts) and workspace-from-invocation-cwd (projection/cli-dispatch.test.ts). Both verified to fail without the src fixes. Unit (28) + projection (23) tests,tsc --noEmit,rslintall green after rebase onto latest main.