Skip to content

fix(state): keep the sqlite close finalizer infallible (#201 follow-up) #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScriptedAlchemy merged 3 commits into from
Sep 1, 2026
Merged

fix(state): keep the sqlite close finalizer infallible (#201 follow-up) #208

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab733a7
fix(ci): keep route-unit proofs out of the example plain test pool
ScriptedAlchemy Sep 1, 2026
b7bc946
fix(ci): defer to the mainline Skill IR digest canonicalization (#191)
ScriptedAlchemy Sep 1, 2026
ee36086
fix(state): keep the sqlite close finalizer infallible (#201 follow-up)
ScriptedAlchemy Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/rsc-runtime/src/state/sqlite.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,9 +849,13 @@ export const createSqliteStateDriver = (options: SqliteStateDriverOptions): Agen
const close = sqliteEffect(definition.id, 'close database', () => {
db.close();
}, true);
// Release finalizers are infallible by contract: a close failure
// on the success path surfaces as a defect instead of being
// silently swallowed, while a failing path keeps the original
// failure as the cause.
return Exit.isFailure(exit)
? close.pipe(Effect.catch(() => Effect.void))
: close;
: close.pipe(Effect.orDie);
},
);
const runtime = makeScopedEffectRuntime(
Expand Down
Loading