fix(state): preserve legacy results and harden driver close (#201 follow-ups) - #213
Merged
Conversation
🦋 Changeset detectedLatest commit: 1777a66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the three unresolved Codex review findings on #201 (and reconciles with #208):
sqlite.ts:720): during a schema-version migration, legacy event rows with no stored committed result are no longer reconstructed viadefinition.reduce, which could fabricate states that never existed once the reducer/shape changed. The journal-head row's result is recovered from the authoritative materialized head; earlier unrecoverable rows now fail closed with a typedmigration-failureerror and an actionable message.sqlite.ts:854):open()now suppresses aruntime.close()failure on the initialization-error path so the original corruption/migration error reaches the caller. The fix(state): keep the sqlite close finalizer infallible (#201 follow-up) #208 infallible-finalizer contract (orDie on the success path) is untouched.close()attempts all store closures, then rethrows the first failure, instead of abandoning later stores after the first rejection.Tests
fails closed when a non-head legacy event has no recoverable committed resultmigrates a legacy journal-head result from the materialized head without using the current reducer(shape-changing v1→v2 migration)preserves the initialization error when database close also failsattempts every store close before propagating the first close failureGates: scoped rstest (83 passed),
pnpm typecheck,pnpm lint— all green.