fix(validate): fail strict validation on Claude probe failures and resolve plugin paths (#193 follow-ups) - #215
Merged
Merged
Conversation
…solve plugin paths (#193 follow-ups)
🦋 Changeset detectedLatest commit: fe9f381 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the two unresolved P2 Codex findings on #193 in
claude-plugin-validation.ts::93):options.pluginDirectoryis resolved to an absolute path up front; the childcwdand theplugin validateargument both derive from it, so a multi-segment relative path likefixtures/pluginno longer double-resolves asfixtures/fixtures/plugin.:97): a probe that times out, exceeds the output limit, exits nonzero, or fails to spawn for any reason other than ENOENT now returns statusfailedwith anAB6022error (with a probe-specific recovery hint), sovalidate --artifact --strictno longer exits successfully when host validation never ran. Only a genuinely missing executable (ENOENT) keeps the informationalAB6019/unavailableresult.Tests
New cases: probe timeout, nonzero exit, output-limit, and non-ENOENT spawn error each →
failed+ AB6022; ENOENT staysunavailable+ AB6019; multi-segment relative directory asserts absolute args and correct cwd via the injectable run seam.Gates: scoped rstest (claude-plugin-validation + artifact-validator),
pnpm typecheck,pnpm lint— all green.