fix(workbench): repeated-flag usage, optional-boolean omission, stale MCP prefill rejection - #226
Merged
Merged
Conversation
…n, stale MCP prefill rejection Mark repeatable named options with the generated help's ` ...` suffix, keep optional undefaulted booleans out of the draft until explicitly set, and surface a missing-tool notice instead of attaching prefilled arguments to the first advertised tool.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🦋 Changeset detectedLatest commit: 1e2b8b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folds the three post-merge Codex P2 findings on #222/#224 into fixes.
Fixes
routes-model.tscliCommandUsage): non-positional options from array schemas now append the same...repetition marker the generated CLI help prints (cli-entry.tsoption rows): required--source <string> ..., optional[--tag <string> ...]. Booleans cannot repeat (the grammar rejects boolean arrays), so flag rendering is otherwise unchanged.routes-model.ts+routes-page.tsx): an optional boolean without a schema default no longer initializes tofalse— it stays out of the draft and renders as a three-state select ((omitted)/true/false), so an untouched field is genuinely omitted from the validated arguments and the MCP prefill, while an explicitfalsestill travels asfalse. Required and defaulted booleans keep their checkbox. The flagship e2e now assertsstrictis omitted from the prefilled arguments unless explicitly set.mcp-page.tsx): a non-empty tool selection that the live session does not advertise no longer falls back totools[0]. The prefill aside states the server no longer advertises the tool and no call control is rendered, so prepared arguments can never attach to a different tool; picking any advertised tool starts with empty arguments (manual selection already resets them). The plain manual flow (empty selection defaults to the first advertised tool) is unchanged.Verification
pnpm typecheck,pnpm lint: clean.strictprefill, and the existing stale→repair legs.