fix(test): force-close the MCP App bridge when the initial tool result publication is rejected - #227
Merged
ScriptedAlchemy merged 1 commit intoSep 1, 2026
Conversation
…t publication is rejected
🦋 Changeset detectedLatest commit: 7974390 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ScriptedAlchemy
deleted the
fix/browser-bridge-close-on-rejected-publish
branch
September 3, 2026 05:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mountBrowserAppnow force-closes the MCP App bridge (mirroring the timeout and handshake-failure paths) when the initialpublishToolResultis rejected by the 1 MiB queued-host-message limit, so the test-suppliedcloseBindingoperation runs instead of leaking the binding.closeBindingwas invoked; verified to fail without the source fix.Addresses the unresolved P2 Codex finding on #212 (
packages/agent-bundle/src/test/browser.ts:365-368).Test plan
pnpm test:unit packages/agent-bundle/tests/test-browser-mount.test.ts(pass; fails without the fix)pnpm typecheck(clean after runtime build)pnpm lint(0 errors, 0 warnings)