fix(inspect): account composite plugin component emission as host-side dispatch, not intersected claims - #230
Merged
Conversation
…e dispatch, not intersected claims
🦋 Changeset detectedLatest commit: b9f02fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugintarget emitscommands/through its Claude side andrules/through its Cursor side, but inspect's skip accounting consulted the honest three-host capability intersection (fix(cursor): honest workspace/open, real marketplace, three-host composite intersection #221), so the same emitted command/rule was also reported as skippedunsupported-capability— contradictory inspection data.unionCapabilityStatesdispatch combinator ("a composite emits a surface if any host side does") and an optionalTargetAdapter.componentCapabilitiesinspection view; the plugin adapter populates it with three-host unions for the component kinds (commands/hooks/mcp/rules/skills).inspect()usescomponentCapabilities ?? capabilitiesfor skip accounting.pluginAdapter.capabilitiesstays the fix(cursor): honest workspace/open, real marketplace, three-host composite intersection #221 three-host intersection, so capability reports, registry records, and manifest fingerprints are unchanged. Registry validation covers the new field.Addresses the unresolved P2 Codex finding on #219 (
packages/agent-bundle/src/api.ts:463-487).Test plan
api.test.ts,plugin-bundle.test.ts,host-adapters.test.ts(75 tests) plus unitadapter-capability-states.test.ts— the extended fixture asserts the plugin target emitscommands/shared.md/rules/shared.mdcAND reports onlyexcluded-by-targetsskips; fails without the api.ts changepnpm typecheck/pnpm lintclean