Skip to content

fix(dev): keep the optional runtime peer out of emitted declarations; exact document-stage locators - #235

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
wave5/main-ci-fixes
Sep 1, 2026
Merged

fix(dev): keep the optional runtime peer out of emitted declarations; exact document-stage locators#235
ScriptedAlchemy merged 1 commit into
mainfrom
wave5/main-ci-fixes

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Repairs the two main CI failures introduced by #231's merge (Verify jobs red on 8a5b42586; merged --admin on pending-only checks, so they first surfaced post-merge).

Fixes

  1. public-api.test.ts — packed root declarations no longer compile for consumers. runtime-routes.ts type-imported AgentRenderEvent/AgentRenderLimits from the optional @agent-bundle/runtime peer at top level, and the exported AgentDocumentRuntimeModule surfaced them — so the emitted root declarations referenced a module consumers may not have installed. The module interface is now purely structural (decodeAgentFlight(flight, signal): AsyncIterable<unknown>): the lazy loader closes over the peer's decodeAgentFlightStream + DEFAULT_AGENT_RENDER_LIMITS inside the function body, events stay opaque (the route only re-serializes them), and nothing peer-typed reaches declaration emit. Behavior (limits, abort on the AB8209 budget, AB8207/AB8208 diagnostics) unchanged; test fakes updated to the structural shape.
  2. runtime-inspector.test.ts strict-mode violation. getByLabel('Agent Document') substring-matches both the stage region and the "Agent Document event timeline" aside; the assertions now use { exact: true }.

Verification

  • pnpm typecheck (incl. examples) and pnpm lint: clean.
  • public-api.test.ts: all green (previously-failing declaration test passes).
  • runtime-inspector.test.ts "renders the six accessible panels…": 1/1.
  • Unit slices (agent-bundle + workbench): 2,068 passed / 0 failed.

@changeset-bot

changeset-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f0453aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
agent-bundle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T23:29:13.886942Z f0453aa PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@pkg-pr-new

pkg-pr-new Bot commented Sep 1, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle@235
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/create-agent-bundle@235
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/@agent-bundle/runtime@235

commit: f0453aa

@ScriptedAlchemy
ScriptedAlchemy merged commit 64aaab0 into main Sep 1, 2026
10 checks passed
@ScriptedAlchemy
ScriptedAlchemy deleted the wave5/main-ci-fixes branch September 1, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant