fix(dev): keep the optional runtime peer out of emitted declarations; exact document-stage locators - #235
Merged
Merged
Conversation
…and disambiguate the document stage locator
🦋 Changeset detectedLatest commit: f0453aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs the two main CI failures introduced by #231's merge (Verify jobs red on
8a5b42586; merged--adminon pending-only checks, so they first surfaced post-merge).Fixes
public-api.test.ts— packed root declarations no longer compile for consumers.runtime-routes.tstype-importedAgentRenderEvent/AgentRenderLimitsfrom the optional@agent-bundle/runtimepeer at top level, and the exportedAgentDocumentRuntimeModulesurfaced them — so the emitted root declarations referenced a module consumers may not have installed. The module interface is now purely structural (decodeAgentFlight(flight, signal): AsyncIterable<unknown>): the lazy loader closes over the peer'sdecodeAgentFlightStream+DEFAULT_AGENT_RENDER_LIMITSinside the function body, events stay opaque (the route only re-serializes them), and nothing peer-typed reaches declaration emit. Behavior (limits, abort on the AB8209 budget, AB8207/AB8208 diagnostics) unchanged; test fakes updated to the structural shape.runtime-inspector.test.tsstrict-mode violation.getByLabel('Agent Document')substring-matches both the stage region and the "Agent Document event timeline" aside; the assertions now use{ exact: true }.Verification
pnpm typecheck(incl. examples) andpnpm lint: clean.public-api.test.ts: all green (previously-failing declaration test passes).runtime-inspector.test.ts"renders the six accessible panels…": 1/1.