Skip to content

fix: harden project config and workspace identity - #320

Merged
ScriptedAlchemy merged 15 commits into
mainfrom
fix/review-batch4-config-project
Sep 3, 2026
Merged

fix: harden project config and workspace identity#320
ScriptedAlchemy merged 15 commits into
mainfrom
fix/review-batch4-config-project

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

  • reject reserved artifact output roots without filesystem case assumptions
  • include executable state in source freshness and skip escaped payload roots until validation reports their target-specific diagnostics
  • derive native event workspace identity from the first workspace_roots entry when cwd is absent, with scalar multi-root semantics documented

Test plan

  • pnpm exec rstest run packages/agent-bundle/tests/normalization.test.ts packages/agent-bundle/tests/dev-services.test.ts --config rstest.unit.config.ts
  • full target-hook-contract.test.ts and generated-route-server.test.ts integration suites
  • feat(cursor): support workspace/open event routes as fire-and-forget observation #298 workspaceOpen envelope, route projection, and lifecycle replay tests
  • pnpm build
  • pnpm typecheck
  • pnpm lint

Preserve safe project identity and diagnostics across case-insensitive outputs, executable payloads, escaped symlinks, and multi-root native events.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T22:31:49.251052Z a45992e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@pkg-pr-new

pkg-pr-new Bot commented Sep 2, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle@320
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/create-agent-bundle@320
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/@agent-bundle/runtime@320

commit: 1956404

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a45992e40d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/agent-bundle/src/dev/project-service.ts
Keep source snapshot, project context, artifact manifest, and publication checks on one executable-aware revision identity.
@changeset-bot

changeset-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1956404

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
agent-bundle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…fig-project

# Conflicts:
#	packages/agent-bundle/tests/manifest.test.ts
Assert the package version now returned by the completed project identity migration.
Assert the newly pinned Codex validation report alongside Claude in installed-tarball coverage.
…fig-project

# Conflicts:
#	packages/workbench/tests/overview.e2e.test.ts
Cover both installed and unavailable Codex CLI outcomes in packed host validation.
…fig-project

# Conflicts:
#	packages/agent-bundle/tests/packed-consumer.test.ts
Follow the src/skills convention and account for the host-proxy event subscription added on main.
@ScriptedAlchemy
ScriptedAlchemy merged commit 134353e into main Sep 3, 2026
9 checks passed
@ScriptedAlchemy
ScriptedAlchemy deleted the fix/review-batch4-config-project branch September 3, 2026 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant