feat(workbench): state-lifetime catalog in the compiled route manifest (#269) - #323
Merged
Conversation
Restore local policy defaults and a cross-package drift guard so static compiler consumers do not require the optional runtime peer.
🦋 Changeset detectedLatest commit: d979031 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deliverable 1 of 2 for #269 (the #98 visibility remainder split from #233 when #268 shipped the existing-surface half): the compiled route manifest now carries the normalized state declaration, and the Workbench Routes page displays it as a read-only catalog panel (G6: zero mutation affordances).
routeManifestForgains an optional normalized state input;RouteManifest.state?: RouteManifestStatecarries declared id, effective lifetime, driver kind (memory/sqlite, mirroring entry codegen), budgets as{ source: 'declared' | 'defaults', resolved }or{ source: 'dynamic' }(statically unreadable), the described (never fabricated) workspace-durable location, the notice-ledger co-mount note, and the conventionalsrc/state.tssource. Absence stays honest: a stateless project's manifest simply omits the field.inspect --state(feat(state): kernel budgets and lifetime visibility (#233 items 3-4) #268) and the manifest lives insrc/core/state-inspection.ts. Static inspection stays independent of the optional@agent-bundle/runtimepeer — local frozen policy defaults with a cross-package drift-guard test comparing them against the runtime'sAGENT_STATE_DEFAULT_BUDGETSexport, so consumers loading compiler APIs without the peer cannot crash and the two package boundaries cannot drift silently.RouteManifestStateexported throughsrc/contracts/routes.ts; the WorkbenchRouteManifestClientdecodes it withz.strictObjectthroughout (an unknown field insidestatefails loudly underAB8123).role="alert". Coordinates with the compiled-graph catalog from feat(workbench): compiler-manifest-driven navigation and route catalog (#105 stage 1) #211 unchanged — no new page, shell, or router.Per the #218 stage-2/3 deferral notes: the static half of the state-lifetime assertions is now wireable from the manifest; the runtime-identity half rides the companion #269 PR.
Test plan
pnpm build,pnpm lint(0/0),pnpm typecheckpnpm test:unit,pnpm test:route-unit,pnpm test:projectionexamples-real.e2e.test.ts): flagshipaudiobook-curatorshows the populated workspace-durable/sqlite panel with zero mutation affordances;mcp-appshows honest absenceAGENT_STATE_DEFAULT_BUDGETSagent-bundleminor