Move conventional authored documents under src/ (skills, commands, rules) - #325
Merged
Conversation
Skills, commands, and rules now discover from src/skills/, src/commands/, and src/rules/, matching every other authored-source convention (routes, state). Top-level locations are no longer discovered; AB4736 reports any legacy document as a deterministic error so nothing vanishes silently. Explicit skills config paths remain valid anywhere; published artifact layout (skills/, commands/, rules/ inside bundles) is unchanged.
Move authored skill trees in audiobook-curator, mcp-app, skills-starter, and the create-agent-bundle minimal template from top-level skills/ to src/skills/, and update READMEs, config comments, scaffolder tests, and workbench test fixtures to the blessed layout.
🦋 Changeset detectedLatest commit: 51907d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/. Conventional discovery moves from top-levelskills/*/SKILL.{md,ts,tsx},commands/*.md, andrules/*.mdctosrc/skills/,src/commands/, andsrc/rules/, matching every other authored surface (src/mcp,src/events,src/providers,src/cli,src/scripts,src/state.ts).assets/stays top-level: static resources are not authored source (the Next.jspublic/analogue). Documented indocs/framework-mode.md.AB4736(migration family,docs/diagnostics.md) reports every unclaimed legacy-location document as a deterministic error with a move-to-src/recovery. A top-level skill covered by explicitskillsconfig stays claimed and valid — explicit config paths work anywhere, unchanged. Removal is safe: thecommands//rules/surfaces are still unreleased changesets and the package is pre-1.0; the break is recorded in a minor changeset.skills/<name>/SKILL.md,commands/,rules/— that contract is separate from source discovery.audiobook-curator,mcp-app,skills-starter), thecreate-agent-bundleminimal template, framework/workbench/scaffolder tests and fixtures, and README tours. This aligns with Compile capability-aware host component bundles #100, which already namessrc/commands,src/agents,src/rulesas the conventional roots.Gates
pnpm typecheck,pnpm lint: clean (post-rebase over fix(test): harden installed-host verification #318/Finish identity migration and expose Workbench provenance #322).pnpm testfull suite: green except two failures that reproduce identically on cleanmainat b1cfe9e (examples-contractpins 17 curator routes but Restructure the audiobook-curator example as a composed React application #315 made it 18;hooks.test.tsCursor workspace/open wrapper hitsERR_MODULE_NOT_FOUND @agent-bundle/runtime) — pre-existing, not from this branch. Post-rebasetest:unit: 2578 passed / 0 failed.pnpm examples:check: all six examples validate, build, and pass tests on thesrc/skills/layout.Coordination
wave/audiobook-react-idiomhas no commits or PR yet; this lane's audiobook changes are only the skill move plus README/config comment lines, so the file sets stay disjoint with that lane's component work.