feat(doctor): surface static bytes-at-rest validation findings (#133) - #340
Merged
Conversation
Reuse process-free pinned host validation lanes so Doctor detects corrupt supplied bundles and installed Cursor plugins without misclassifying loader-supported manifest flavors.
🦋 Changeset detectedLatest commit: eb0e732 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 2, 2026
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The final #133 slice: the read-only install Doctor now surfaces pinned static bytes-at-rest validation findings, reusing the ecosystem validators this issue landed — never spawning host CLIs, never repairing, never exchanging live protocol traffic (that lane stays with #218).
validateClaudePluginFiles(drives the Claude adapter's own pinned document contracts incl. wildcard paths),validateCodexPluginFiles(the pinned-document lane extracted from feat(codex): validate bundles against pinned schemas with honest host-devtools evidence (#133) #326), andvalidateCursorPluginFiles/validateCursorPluginSymlinks(extracted from feat(cursor): validate bundles against pinned schemas and loader contract with honest devtools evidence (#133) #327, with a parameterizable symlink-containment root).validateClaudePlugin/validateCodexPlugin/validateCursorPluginbehavior is unchanged (they now compose the exported lanes).doctor --from(AB7319): each host tree resolved from the supplied bundle is validated against its pinned document schemas and process-free loader rules; error findings demote the bundle finding tocorruptand retain the originating build-validator code in the message..cursor-plugin/plugin.jsonmanifest get the full pinned lane (document schemas, token-location rules); plugins using the other loader-accepted manifest flavors (.claude-plugin/plugin.json, rootplugin.json— pinned as legitimately loadable, incl. the portable: adopt Agent Plugins 1.0.0 as the pinned portable contract #306 portable dogfood proof) are NOT branded corrupt: they get an honest info naming the flavor plus the one check that is loader-pinned for every local plugin — symlink realpath containment within~/.cursor/plugins/local(not the individual plugin directory, matching the pinned rejection rule).diagnosticsarrays and the existingcorruptstate, so the Workbench discovery contract, service mapping, and decoder are untouched; CLI human/--jsonoutput and exit-code semantics (nonzero only on errors) are unchanged.AB7319–AB7320registered (AB7317/7318 were taken by the runtime-identity lane that landed mid-wave).Changeset: minor,
agent-bundle.Test plan (all local, on the rebase over 27a0d59)
pnpm buildpnpm typecheckpnpm lint— 0 errors, 0 warnings (1018 files)pnpm test:unit— 2624 passed, 0 failed.cursor-plugininstall →corrupt+ AB7320 error;.claude-plugin/plugin.jsonflavors stayinstalledwith honest info; local-root symlink escape → corrupt, intra-local-root symlink → clean;--fromstatic findings per host; fixtures upgraded to pinned-schema-valid bytesTracking